-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Improve User Interaction Clarity for Polygon Drawing Tool in Bokeh 3.4.x #13842
Comments
In bokeh 3.4 we had to replace double tap gesture with press gesture in edit tools and others, due to changes in UI gesture recognition. Press on the canvas to add the first vertex, then tap to added subsequent vertices and press again to finalize drawing. |
When i try the latest example poly_draw.html i'm not able to add new patches or multi-lines by press(single tap?). I get the same unexpected behaviour if i run the example locally. $ bokeh info
Python version : 3.11.8 (main, Feb 12 2024, 14:50:05) [GCC 13.2.1 20230801]
IPython version : (not installed)
Tornado version : 6.4
Bokeh version : 3.4.1
BokehJS static path : /home/fredrik/Documents/git/bokeh/bokeh_server/myapp_one/.venv/lib/python3.11/site-packages/bokeh/server/static
node.js version : v21.7.3
npm version : 10.5.2
jupyter_bokeh version : (not installed)
Operating system : Linux-6.8.7-arch1-1-x86_64-with-glibc2.39 |
@angelsen the first tap has to be a "long" press, I don't think this docs are clear on this point. The UX is also presently lacking significantly in that there is no indication that the tool has been activated after the long press, or even after the second tap. Nothing shows up at all until a third vertex is dropped, which makes it very hard to judge what the tool is doing. cc @philippjfr |
I'd have to look at this again in more detail and am away from my computer at least until Tuesday but iirc @mattpap made some significant changes to the UX of the draw/edit tools that may not have been documented. |
Regardless of the documentation, the current UX is fairly impossible to navigate out of the box. There are no visual cues that anything at all is happening at all, until after a long press and two taps happen. It's very easy to imagine why users thinks it is just not working. |
Yes, it's pretty clear this needs another in-depth look. I'm out of office until tomorrow, in the meantime @mattpap could you summarize what was changed here an why. |
The only recent and intentional change to edit/draw tools was replacement of double tap gesture with press tap. It was documented, but perhaps it wasn't advertised sufficiently. However, I myself have a problem with understanding whether the relevant tools actually work or not, at least without consulting documentation and source code. We previously discussed the possibility of redesigning those tools, but nothing came to fruition yet. |
I believe it would be beneficial for users if the documentation included a dedicated section explaining the different gesture interactions required for tools in Bokeh. If such documentation already exists, it would be helpful to have it linked directly within the sections where these tools are described or discussed. |
@angelsen can you be more specific with your suggestion, e.g. what exact pages you have in mind? Currently there is an entire user guide chapter dedicated to tools: https://docs.bokeh.org/en/latest/docs/user_guide/interaction/tools.html with a subsection for edit tools, where all the individual edit tools have their own subsections such as https://docs.bokeh.org/en/latest/docs/user_guide/interaction/tools.html#boxedittool each with descriptions like this for their use:
|
E.g., when i read the documentation for PolySelectTool i wouldn't know, now i do, that Ideally this should be intuniv and a user shouldn't be required to read the documentation, but developers do and could guide a user via tooltips etc. |
So, I think the main priority is to improve the UX so that it is more intuitive, and then in whatever PR does that, update the docs to match. I agree that "press tap" is ambiguous since "press" can can function as different parts of speech in this case and it is not evident which one is intended. |
Software versions
Python version : 3.11.8 (main, Feb 12 2024, 14:50:05) [GCC 13.2.1 20230801]
IPython version : (not installed)
Tornado version : 6.4
Bokeh version : 3.4.1
BokehJS static path : /home/fredrik/Documents/git/bokeh/bokeh_server/myapp_one/.venv/lib/python3.11/site-packages/bokeh/server/static
node.js version : v21.7.3
npm version : 10.5.2
jupyter_bokeh version : (not installed)
Operating system : Linux-6.8.7-arch1-1-x86_64-with-glibc2.39
Browser name and version
Google Chrome 124.0.6367.78
Jupyter notebook / Jupyter Lab version
No response
Expected behavior
Steps to Reproduce
Expected Behavior
The tool should allow setting an initial vertex with a double-click, adding vertices with further clicks, and completing the drawing with the ESC key, as it works in version 3.3.4.
Observed behavior
Actual Behavior
Example code
Stack traceback or browser console output
Additional Context
This issue was initially pointed out in a forum discussion here.
Screenshots
No response
The text was updated successfully, but these errors were encountered: