-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] NumPy 2.0 support #13835
Comments
cc @bokeh/dev I have triaged this as task. For reference I tried several Bokeh server app examples with
|
There only seem to be a handful of relevant unit test failures
|
ContourPy 1.2.1 supports NumPy 2.0. For me, all the contour-based examples and tests work for bokeh >= 3.4.1, contourpy 1.2.1 and NumPy 2.0.0rc1. @bryevdv I suspect you are trying to use ContourPy 1.2.0 (which does NOT support NumPy 2.0) rather than 1.2.1 here. |
@ianthomas23 apparently so, I was testing things on two different machines, and only one of them had As of now I only see one failing unit test (on OSX) with 2.0.0rc1, and it does pass with 1.26 installed
|
Switching to use the
I will try to stand up a CI job with 2.0.0rc if this is the only failure then we should cut a 3.4.2 soon. Edit: actually if this is the only failure, then I think we could claim that released 3.4.1 already supports numpy 2.0 since this is just the text of the error message and not the exception. |
Problem description
NumPy 2.0 is coming out soon ( numpy/numpy#24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out 3 weeks back ( numpy/numpy#24300 (comment) )
Feature description
To prepare for NumPy 2.0, it might be worthwhile to start testing Bokeh against NumPy 2 in CI
Also as NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share Bokeh's current support status in issue (with any plans): numpy/numpy#26191
NumPy has put out a migration guide. More details are in the release notes. As Bokeh doesn't have C/C++ usage of NumPy, only the Python changes would be relevant
Potential alternatives
In the short term, Bokeh may wish to set an upper bound on NumPy version until testing can happen. Alternatively Bokeh could wait for user issues and address as those come up
Maybe there are other options that haven't been considered here
Additional information
It appears Bokeh depends on ContourPy, which may also need updates. Filed upstream issue: contourpy/contourpy#378
The text was updated successfully, but these errors were encountered: