Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is extending text/uri-list with magic comments a good idea? #6

Open
domenic opened this issue Mar 22, 2023 · 1 comment
Open

Is extending text/uri-list with magic comments a good idea? #6

domenic opened this issue Mar 22, 2023 · 1 comment

Comments

@domenic
Copy link

domenic commented Mar 22, 2023

It's pretty clever. But adding load-bearing comments to any format is fraught, and this seems like no exception. I can see pros and cons, but let me focus this issue mostly on the cons, to provide a counterpoint to the current explainer.

If the idea is to reuse an existing format to take advantage of existing content, then there might be compat concerns with that existing content. Or, concerns about the existing software/users that consume text/uri-list content, being confused by all these page-collections-oriented comments showing up in their ecosystem.

On the other hand, if you think that there is likely not enough existing content out there for compat concerns to manifest, or enough of an ecosystem out there to be confused by these new comments... then is the text/uri-list format really worth building on in the first place?

The requirement that the extended text/uri-list format be isomorphically encodable in a uri-list [sic] scheme is also somewhat restrictive. Although the ? in URL <-> #? mapping is pretty close, the one envisaged in https://github.com/bokand/page-collection#hierarchical-lists is not at all close.

An alternative path that might be worth investigating is a custom format which does not have existing content out there to cause compat and ecosystem concerns. This format could have first-class support for extensibility of the type you're envisioning, and could even be designed from the beginning to be isomorphic to a corresponding URL scheme.

@bokand
Copy link
Owner

bokand commented Apr 4, 2023

Thanks, these are all good points.

I just chatted with @vmpstr about this. The appeal of using text/uri-list is that we're avoiding creating a new type that's almost-but-not-quite the same as an existing one, like x-moz-url.

While we have some hypothetical ideas about how this could be developed in the future, our current requirements for load-bearing comments are all optional/decorative in nature: a name for the group and potentially a "theme color".

IMHO, given this is quite experimental and the proposed extensions to text/uri-list being limited and non-essential to the functionality, I'd still lean to using text/uri-list. But I agree with your concerns so I think we can be more explicit about saying that if the idea proves successful and there's demand for expanded scope we would create a new format for the expanded use cases.

(we may want to reconsider aspects of the scheme in light of this though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants