Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBytesHelper cleanups - LoadFromStream block and CalculateCRC32 #65

Open
bogdanpolak opened this issue Feb 23, 2023 · 0 comments
Open
Projects
Milestone

Comments

@bogdanpolak
Copy link
Owner

  • I wanto to enable loading bytes from a stream into a TBytes, but only portion of stored data. Add: length to LoadFromStream.
  • I want to calculate CRC32 check sum of the whole TBytes content by default. Existing method GetSectorCRC32 is expecting a start index and a length. I wont to rename method to calculateCRC32 and allow to call it without parametrs
procedure LoadFromStream(const aStream: TStream; const aLength: integer);
// before: procedure LoadFromStream(const aStream: TStream);
function CalculateCRC32(aIndex: Integer = 0; aLength: Integer = 0): LongWord;
// before: function GetSectorCRC32(aIndex: Integer; aLength: Integer): LongWord;
@bogdanpolak bogdanpolak added this to the 1.9 milestone Feb 23, 2023
@bogdanpolak bogdanpolak added this to To do in Version 1.9 via automation Feb 23, 2023
@bogdanpolak bogdanpolak moved this from To do to In progress in Version 1.9 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1.9
In progress
Development

No branches or pull requests

1 participant