-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting of the stdout text #8
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of the stdout log is inconsistently formatted, or is incorrect. See examples below.
There are several cases where large numbers are displayed with
,
separating 1000's. There are some cases where no,
's are used.In the run that produced this output, the batch size was set to 2.5m guides, yet, below, on the second line, it says the page will contain 5m guides.
The page size would not be larger than the batch size.
I believe
pageSize = min(batchSize, maxPageSize, actualPageSize)
would be more accurate.Also, notice the lack of commas again.
The text was updated successfully, but these errors were encountered: