Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequence number doesn't match tiff numbers #30

Open
EliotGann opened this issue Nov 14, 2019 · 2 comments
Open

sequence number doesn't match tiff numbers #30

EliotGann opened this issue Nov 14, 2019 · 2 comments

Comments

@EliotGann
Copy link

A user just noticed that the seq_num in the csv suitcase is off by one from the tiff numbers in the filenames created from suitcase-tiff. seq_num starts at 1, tiff suitcases start at 0. seems like they should be consistent.

@danielballan
Copy link
Member

Yeah....an Original Sin of bluesky is that we caved to pressure to start the sequence number at 1 "because that's how SPEC does it" even though everything in Python / SciPy land starts at 0. Without taking a position on which is "right", I do think we should have been consistent with Python here.

Can folks weigh in with an opinion on whether the 1-indexing should propagate into the file names?

@st3107
Copy link

st3107 commented Nov 24, 2020

Just curious whether this issue has been settled down. I am writing suitcases to export 1 dimesion numpy array in data to csv files. I would like the file name to be consistent with the other suitcase packages. However, I found that the indexing of suitcase-tiff and suitcase-csv are different. I wonder which indexing method (1-indexing or 0-indexing) will be chosen as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants