Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDS's firehose can skip cursor values #2400

Open
imax9000 opened this issue Apr 10, 2024 · 0 comments
Open

PDS's firehose can skip cursor values #2400

imax9000 opened this issue Apr 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@imax9000
Copy link

Describe the bug

When connecting to PDS's firehose with a previous cursor, it occasionally skips a few sequential cursor values without emitting #info message.

To Reproduce

Steps to reproduce the behavior:

  1. Connect to wss://agaric.us-west.host.bsky.network/xrpc/com.atproto.sync.subscribeRepos?cursor=13892059 sometime within the next hour
  2. Read seq field from the first received message

Expected behavior

13892060

Actual behavior

13892061

Additional context

Yes, I know that the spec does not say they have to be sequential. But they are in the current implementation, and I'm checking the increment to detect a reset when connecting to Relay's firehose, which does not emit #info at all, so there's no other way to know if there's a break in continuity.

@imax9000 imax9000 added the bug Something isn't working label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant