Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port/esp32: a bunch of improvements #381

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SalimTerryLi
Copy link

@SalimTerryLi SalimTerryLi commented Oct 8, 2021

This PR most likely will bring IDF version requirement to V4.3 or later, and may drop support for an unknown old version...

Things that happened here

  • use ${IDF_PATH} instead of relative path in component CMakeList
  • replace sdkconfig with new sdkconfig.defaults
  • update default Kconfig options to disable Bluedroid
  • add support for idf-component-manager

Notes

I'm doing a fork and publishing the one that can be directly used without integrate_btstack.py with the help of Github workflow, because currently I cannot find a proper way to make it available in upstream...

@SalimTerryLi SalimTerryLi marked this pull request as ready for review October 8, 2021 11:11
@mringwal
Copy link
Member

Hi @SalimTerryLi Thanks for the "bunch of improvements". I'm sorry I didn't go through them in October. We also updated the ESP32 build similar to your improvements (e.g. use IDF_PATH, update the sdkconfig to 4.3 and Bluedroid disable).

Could you rebase to develop and check what improvements still apply? Thanks!

@SalimTerryLi SalimTerryLi force-pushed the pr-esp32-minor_improvements_build_system branch from 98873f0 to 24a762a Compare February 11, 2022 05:46
@SalimTerryLi
Copy link
Author

SalimTerryLi commented Feb 11, 2022

I'd want to purge the use of create_examples.py as well as integrate_btstack.py. Could you please take a look at https://github.com/SalimTerryLi/btstack/tree/test-complete_tree_as_component/port/esp32 and see if the solution is acceptable? It is the way https://github.com/lvgl/lvgl works.

There's no need to place BTstack into IDF tree, breaking its git context, and also no need to use those ugly python scripts to setup the environment.

If it's not acceptable to place those random yaml and CMakeLists into BTstack root for some reason, then is it OK to setup some GitHub Action for automatically integrating and publishing?

I've made the change based on the latest IDF master branch, which should be v5.0-dev now. But it can be expanded to at least V4.3 I think. For the non-idf-component-manager use case, users can add BTstack repo as an submodule under the EXTRA_COMPONENT_DIRS path. Still provides better integration.

@mringwal
Copy link
Member

@SalimTerryLi thanks for your updates. I'll be away the next week, but will look at your changes after that.
I'd be happy if we don't need to copy BTstack into esp-idf. We'll need to think about the random files in the root folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants