Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Provide minified version #3665

Open
pbartoszek opened this issue Aug 12, 2020 · 2 comments
Open

Provide minified version #3665

pbartoszek opened this issue Aug 12, 2020 · 2 comments
Labels

Comments

@pbartoszek
Copy link

I couldn't find a minified version of this project. I think this might be a main blocker for people trying to use it in theirs project.

@blueimp
Copy link
Owner

blueimp commented Aug 13, 2020

Thanks for your suggestion @pbartoszek.

I provide minified versions for some of my other JavaScript projects, but I'm not sure I want to maintain minified versions for jQuery File Upload.

One reason for this is the modular nature of the components:

  • Should a minified version include all components, including the UI version?
  • Should a minified version include the jQuery UI Widget Library?
  • Should a minified version include the Iframe Transport?
  • Should a minified version include the PostMessage CORS library?
  • Should a minified version include the XDomainRequest Transport, which is included for cross-domain file deletion for IE 8 and IE 9 only?
  • Should there be multiple minified versions?

Another reason is that committing minified versions is not ideal for source control, since every change invalidates the whole minified file.

I think providing a minified bundle still makes sense to quickly include it for use in demos and such, but this practice also encourages folks to include the library directly from Github in their production projects, which is not a recommendable practice.

@gregh3269
Copy link

gregh3269 commented Sep 3, 2020

I copy them from https://cdnjs.com/libraries/blueimp-file-upload?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants