Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add comment about intentional log to bsl::cout #9

Merged
merged 7 commits into from
May 10, 2024
Merged

Docs: add comment about intentional log to bsl::cout #9

merged 7 commits into from
May 10, 2024

Conversation

678098
Copy link
Contributor

@678098 678098 commented Oct 21, 2023

No description provided.

willhoy
willhoy reviewed Oct 31, 2023
View reviewed changes
src/rmq/rmqa/rmqa_connectionimpl.cpp Outdated
@@ -53,7 +53,7 @@ createRetryHandler(const bsl::shared_ptr<rmqio::TimerFactory>& timerFactory,
const rmqt::Tunables& tunables)
{
if (tunables.find("IIR") != tunables.end()) {
bsl::cout << "WARNING: Infinite Immediate Retry Set" << bsl::endl;
BALL_LOG_WARN << "Infinite Immediate Retry Set";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BALL_LOG_WARN << "Infinite Immediate Retry Set";
bsl::cout << "WARNING: Infinite Immediate Retry Set" << bsl::endl; // Intentional print to console

@678098
Copy link
Contributor Author

678098 commented Nov 5, 2023

A problem with permissions

2023-11-05T00:50:42.6460909Z + git push
2023-11-05T00:50:42.6461186Z [gh-pages 868db9d] Auto commit
2023-11-05T00:50:42.6461491Z  1 file changed, 3 insertions(+), 3 deletions(-)
2023-11-05T00:50:42.7159844Z remote: Permission to bloomberg/rmqcpp.git denied to github-actions[bot].

@678098 678098 changed the title Replace bsl::cout log with BALL_LOG Docs: add comment about intentional log to bsl::cout Mar 21, 2024
@willhoy willhoy merged commit 269a508 into bloomberg:main May 10, 2024
5 checks passed
@678098 678098 deleted the patch-2 branch May 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willhoy willhoy willhoy approved these changes

@adamncasey adamncasey Awaiting requested review from adamncasey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@678098 @adamncasey @willhoy