Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bsl::string with std to fix build error #43

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

ahsanabbas123
Copy link
Contributor

@ahsanabbas123 ahsanabbas123 commented Jun 12, 2024

Problem Statement

Build was failing with the errors in rmqio_asioresolver.t.cpp

error: no matching constructor for initialization of 'entry_type' (aka 'basic_resolver_entry<boost::asio::ip::tcp>')
        entries.push_back(entry_type(endpoint, host, port));
                          ^          ~~~~~~~~~~~~~~~~~~~~
/boost/asio/ip/basic_resolver_entry.hpp:53:3: note: candidate constructor not viable: no known conversion from 'bsl::string' (aka 'basic_string<char>') to 'boost::asio::string_view' (aka 'basic_string_view<char>') for 2nd argument
  basic_resolver_entry(const endpoint_type& ep,
  ^

Proposed changes

Changing to std::string should fix build

@ahsanabbas123 ahsanabbas123 changed the title Replace bsl::string with std to fix build Replace bsl::string with std to fix build error Jun 12, 2024
@ahsanabbas123 ahsanabbas123 requested review from willhoy and a team June 12, 2024 14:56
@willhoy willhoy merged commit 43651ae into main Jul 17, 2024
7 checks passed
@willhoy willhoy deleted the fix_resolver_test branch July 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants