Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

Arcyd-tester: push_new_review_branch does not handles slashes in filenames #62

Open
cs-shadow opened this issue Oct 19, 2015 · 0 comments

Comments

@cs-shadow
Copy link
Contributor

push_new_review_branch() writes a file corresponding to each branch and the name of the file is obtained simply by appending the name of branch to the filepath. This logic fails when the name of branch itself has slashes which is a valid case because the function treats it as a directory and hence fails while trying to create the file.

This is a relatively minor issue since this code is just used by the tester and not actually by Arcyd but thought it will still be nice to at least have it documented here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant