feat(meme): hide meme coins from supported list #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-bc
requested review from
TheLeoB,
jjBlockchain,
dkremniov-bc,
mperdomo-bc,
mrodriguez-bc,
CTucker-BC and
jhagerman-bc
as code owners
milan-bc
commented
Oct 8, 2024
| assets[coin.symbol] = { coinfig: coin } | ||
| }) | ||
| supportedCoins | ||
| .filter((coin) => !coin.categories.some((cat) => cat?.id === 'MEME')) |
There was a problem hiding this comment.
we filter supported coins for entire app to prevent showing of them on v4
milan-bc
commented
Oct 8, 2024
| // sardine environment sandbox or production | ||
| _Sardine: any | ||
| // Sardine integration | ||
| _SardineContext: any |
milan-bc
force-pushed
the
feat/BROK-1803-filter-out-meme-coins
branch
from
cf8df7e to
8baa0a0
Compare
|
No New Or Fixed Issues Found |
milan-bc
force-pushed
the
feat/BROK-1803-filter-out-meme-coins
branch
from
220a577 to
9c2cd91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (optional)
Add a concise explanation of the changes.
Testing Steps (optional)
Detail the steps required for the reviewer(s) to verify and test these changes.