Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all possible panics from the main resolver #106

Open
blake-mealey opened this issue Jan 10, 2022 · 1 comment
Open

Remove all possible panics from the main resolver #106

blake-mealey opened this issue Jan 10, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@blake-mealey
Copy link
Owner

This project does a good job of handling error cases, but there are one or two places in the main resolver code which makes assumptions about the graph which should be true but occasionally aren't (I've so far only experienced this as a result of some bugs like #104). When it panics part-way through a resolve, it can sometimes cause some major issues for the next attempt (which can wreck the graph) so these should really be handled properly (even though in a perfect world the assumptions should be true)

@blake-mealey blake-mealey added the bug Something isn't working label Jan 10, 2022
@blake-mealey blake-mealey added this to the v1.0.0 milestone Feb 17, 2022
@blake-mealey
Copy link
Owner Author

Adding to milestone v1.0.0 because this could cause costly mistakes in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant