Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isEmpty is false by default #11

Open
riiiiizzzzzohmmmmm opened this issue Jan 6, 2017 · 0 comments
Open

isEmpty is false by default #11

riiiiizzzzzohmmmmm opened this issue Jan 6, 2017 · 0 comments

Comments

@riiiiizzzzzohmmmmm
Copy link

riiiiizzzzzohmmmmm commented Jan 6, 2017 •
edited
Loading

When signature component is first mounted and no data has been set, isEmpty() returns false when it should return true.
tvkhoa referenced this issue in Thinkei/react-signature-pad Nov 12, 2019
@lopis @agilgur5
(fix): fix broken dotSize function
342ce96 
- this fixes an error that occurred when drawing a single dot that
  would result in the canvas looking empty and the state of the
  component containing a blank image

- this error was introduced in the v0.1.6 release that made dotSize
  a static function instead of defined in the constructor
  - (props to @kgram for catching this in #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riiiiizzzzzohmmmmm