Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI does not show error or prevent you from submitting form #9022

Open
1 task done
alfonsoar opened this issue May 2, 2024 · 1 comment
Open
1 task done

UI does not show error or prevent you from submitting form #9022

alfonsoar opened this issue May 2, 2024 · 1 comment
Labels
browser Browser Extension bug

Comments

@alfonsoar
Copy link

Steps To Reproduce

  1. Go to "Vaults"
  2. Click on 'My Vault"
  3. Select all passwords
  4. Click hamburger button
  5. Click on "Move selected to organization"
  6. Select organization
  7. Click on "Save"

Expected Result

The UI should show an error message informing the user why passwords were not moved or the UI should not allow you to click on save if you do not have collections.

Actual Result

No error is shown to the user

Screenshots or Videos

Screenshot 2024-05-02 at 11 48 07 AM

Additional Context

follow up from: #9019

I noticed the call to https://vault.bitwarden.com/api/ciphers/share failed with a 400:

{
    "message": "The model state is invalid.",
    "validationErrors": {
        "CollectionIds": [
            "You must select at least one collection."
        ]
    },
    "exceptionMessage": null,
    "exceptionStackTrace": null,
    "innerExceptionMessage": null,
    "object": "error"
}

Chrome version:


Google Chrome | 124.0.6367.91 (Official Build) (arm64)
-- | --
Revision | 51df0e5e17a8b0a4f281c1665dbd1b8a0c6b46af-refs/branch-heads/6367@{#984}
OS | macOS Version 13.1 (Build 22C65)
JavaScript | V8 12.4.254.14
User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36
Command Line | /Applications/Google Chrome.app/Contents/MacOS/Google Chrome --restart --restart --flag-switches-begin --flag-switches-end
Executable Path | /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
Profile Path | /Users/alfonso/Library/Application Support/Google/Chrome/Default
Linker | lld
Active Variations | e32097a3-ca7d8d80c75063ef-377be55a

Operating System

macOS

Operating System Version

see above

Web Browser

Chrome

Browser Version

see above

Build Version

see above

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@alfonsoar alfonsoar added browser Browser Extension bug labels May 2, 2024
@alfonsoar
Copy link
Author

It's worth mentioning that to reproduce this you might need to create a new organization but don't create/share a default collection initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

1 participant