Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prowlarr / sonarr / radarr useability #369

Closed

Conversation

rraymondgh
Copy link
Contributor

This change enables clicking on found searches in Prowlarr, radarr and sonarr to view bitmagnet permalink details.

It is odd to have used comments attribute of torznab message. This was assessed by scanning Prowlarr code for how it handles generic torznab indexers. Also discovered that Prowlarr uses leechers not peers in constructing peers n / m column. Where n is seeders and m is leachers.

Also explored using https://wiki.servarr.com/en/prowlarr/cardigann-yml-definition This however results in significant duplication plus fixed list of base URLs. Which really isn't good for a self hosted component where it cannot be pre-determined how someone is hosting and hence a static list of IPs / hostnames

@rraymondgh
Copy link
Contributor Author

fixes issue #273

scheme = "https"
}
return scheme + "://" + c.Request.Host + "/webui/torrents/permalink/"
}
Copy link
Collaborator

@mgdigital mgdigital Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that the user will access Bitmagnet in their browser via the same hostname as the backend Torznab client, which isn't a safe assumption.
I think a base URL would need to be part of configuration, with permalink omitted if this is unconfigured...

@@ -8,7 +8,7 @@ const (
AttrSize = "size"
AttrPublishDate = "publishdate"
AttrSeeders = "seeders"
AttrPeers = "peers"
AttrLeechers = "leechers"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fixes #273 on its own could it be done as a separate PR?

@rraymondgh
Copy link
Contributor Author

superseded by #371

@rraymondgh rraymondgh closed this Jan 25, 2025
@rraymondgh rraymondgh deleted the torznab_leechers_details branch January 25, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants