Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torznab - tmdb missing from response #373

Open
2 tasks done
rraymondgh opened this issue Jan 22, 2025 · 3 comments · May be fixed by #376
Open
2 tasks done

torznab - tmdb missing from response #373

rraymondgh opened this issue Jan 22, 2025 · 3 comments · May be fixed by #376
Labels
enhancement New feature or request

Comments

@rraymondgh
Copy link
Contributor

rraymondgh commented Jan 22, 2025

  • I have checked the existing issues to avoid duplicates
  • I have redacted any info hashes and content metadata from any logs or screenshots attached to this issue

Feature request

Describe the solution you'd like

Simple enhancement to bitmagnet torznab RSS response.

@rraymondgh rraymondgh added the enhancement New feature or request label Jan 22, 2025
@mgdigital
Copy link
Collaborator

mgdigital commented Jan 27, 2025

Should this be 2 separate issues?

The TMDB param is a no brainer; the comments is more complex so best as its own issue

@rraymondgh rraymondgh changed the title torznab - tmdb and comments missing from response torznab - tmdb missing from response Jan 27, 2025
@rraymondgh rraymondgh linked a pull request Jan 27, 2025 that will close this issue
@rraymondgh
Copy link
Contributor Author

I've been looking at requests that sonarr sends to Prowlarr and onto bitmagnet. i.e. tv-search

If capabilities specify tmdbid,imdbid sonarr will send a request parameter with imdbid=12345 when searching.

Looking at my database, there is no data to support this. imdb ID only exists against movies, not a single tv show.

select content_type, content_source, source, key, count(*) 
from content_attributes
group by content_type, content_source, source, key
order by content_type, content_source, source, key
limit 100

Hence sonarr then sends multiple additional search requests with q parameter set. Then this uses FTS.

I have trialed with a version that states q,tmdbid,season,ep as capabilities. In this case sonarr is not setting tmdbid request parameter. Will raise something on sonarr forums and dig through code base. It is clearly reacting to capabilities but not in way I would expect. Prowlarr code base looks to be correct.

@rraymondgh
Copy link
Contributor Author

I have trialed with a version that states q,tmdbid,season,ep as capabilities. In this case sonarr is not setting tmdbid request parameter. Will raise something on sonarr forums and dig through code base. It is clearly reacting to capabilities but not in way I would expect. Prowlarr code base looks to be correct.

Have confirmed this is a bug in prowlarr that should be fixed in todays nightly build (29-jan-2025)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants