Merge bitcoin/bitcoin#33894: net: Remove unused local_socket_bytes variable in CConnman::GetAddresses()

fanquake · fanquake · commit 2444488f6ad3 · 2025-11-18T09:30:24.000Z
4d893c0 net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` (WakeTrainDev) Pull request description: The local_socket_bytes variable was never used. Removed it to clean up dead code. ACKs for top commit: mzumsande: ACK 4d893c0 theStack: ACK 4d893c0 Tree-SHA512: f423bcf975aa2602464fcb96db323cbd6007a7491ddbe119f1d20e890c883dd351a55976151c5d25f5d26267b0efe1f0836fbd65e540c920dac931ed8d67846a
diff --git a/src/net.cpp b/src/net.cpp
@@ -3539,7 +3539,6 @@ std::vector<CAddress> CConnman::GetAddressesUnsafe(size_t max_addresses, size_t
 
 std::vector<CAddress> CConnman::GetAddresses(CNode& requestor, size_t max_addresses, size_t max_pct)
 {
-    auto local_socket_bytes = requestor.addrBind.GetAddrBytes();
     uint64_t network_id = requestor.m_network_key;
     const auto current_time = GetTime<std::chrono::microseconds>();
     auto r = m_addr_response_caches.emplace(network_id, CachedAddrResponse{});

Original file line number	Diff line number	Diff line change
`@@ -3539,7 +3539,6 @@ std::vector<CAddress> CConnman::GetAddressesUnsafe(size_t max_addresses, size_t`
`3539`	`3539`
`3540`	`3540`	`std::vector<CAddress> CConnman::GetAddresses(CNode& requestor, size_t max_addresses, size_t max_pct)`
`3541`	`3541`	`{`
`3542`		`- auto local_socket_bytes = requestor.addrBind.GetAddrBytes();`
`3543`	`3542`	`uint64_t network_id = requestor.m_network_key;`
`3544`	`3543`	`const auto current_time = GetTime<std::chrono::microseconds>();`
`3545`	`3544`	`auto r = m_addr_response_caches.emplace(network_id, CachedAddrResponse{});`