Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Redundant trailing comma on import statement #4334

Open
1 task done
sleewoo opened this issue Oct 18, 2024 · 2 comments · May be fixed by #4454
Open
1 task done

📝 Redundant trailing comma on import statement #4334

sleewoo opened this issue Oct 18, 2024 · 2 comments · May be fixed by #4454
Assignees
@fireairforce
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@sleewoo
Copy link

sleewoo commented Oct 18, 2024

Environment information

➜ biome rage --formatter
CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v22.6.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Formatter:
  Format with errors:           false
  Indent style:                 Space
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   80
  Attribute position:           Auto
  Bracket spacing:              BracketSpacing(true)
  Ignore:                       []
  Include:                      []

JavaScript Formatter:
  Enabled:                      true
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              unset
  Bracket same line:            false
  Quote style:                  Double
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           unset

JSON Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

GraphQL Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Bracket spacing:              unset
  Quote style:                  unset

Workspace:
  Open Documents:               0

Configuration

{
  "$schema": "https://biomejs.dev/schemas/1.9.0/schema.json",
  "formatter": {
    "indentStyle": "space",
    "indentWidth": 2
  },
  "linter": {
    "enabled": true,
    "rules": {
      "complexity": { "noUselessTernary": "off", "useLiteralKeys": "off" },
      "style": {
        "useFilenamingConvention": {
          "level": "error",
          "options": {
            "strictCase": true,
            "requireAscii": true,
            "filenameCases": ["kebab-case", "snake_case", "PascalCase"]
          }
        }
      },
      "suspicious": {
        "noConsole": "error"
      }
    }
  }
}

Playground link

https://biomejs.dev/playground/?indentStyle=space&code=ZQB4AHAAbwByAHQAIAB0AHkAcABlACAAQQBjAHQAaQBvAG4ATABvAGcAcwBRACAAPQAgAGkAbQBwAG8AcgB0ACgAIgBAAGEAcABwAHIAaQBsAC8AZABiAHgAdAAiACkALgBRAHUAZQByAHkAQgB1AGkAbABkAGUAcgA8ACIAYQB1AGQAaQB0AC4AYQBjAHQAaQBvAG4AXwBsAG8AZwBzACIAPgA7AAoA

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@sleewoo sleewoo added the S-Needs triage Status: this issue needs to be triaged label Oct 18, 2024
@sleewoo
Copy link
Author

sleewoo commented Oct 18, 2024 •
edited
Loading

before format

export type ActionLogsQ = import("@appril/dbxt").QueryBuilder<"audit.action_logs">;

expected
image

actual
image

@vohoanglong0107 vohoanglong0107 added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug and removed S-Needs triage Status: this issue needs to be triaged labels Oct 19, 2024
@simon-paris simon-paris mentioned this issue Oct 29, 2024
Closed
1 task
@fireairforce
Copy link
Contributor

i'd like to work on this.

@fireairforce fireairforce linked a pull request Nov 3, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fireairforce fireairforce

Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js_formatter): don't insert trailing comma on type import statement fireairforce/biome
3 participants
@fireairforce @sleewoo @vohoanglong0107