Skip to content

Commit 8db9ebc

Browse files
benjaminpaperbenni
authored andcommitted
chore: make shellcheck happy
unquoted variables and find without argument and read -r
1 parent f68ba20 commit 8db9ebc

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

images/base-glibc-busybox-bash/install-pkgs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -103,20 +103,20 @@ prepare() {
103103
libtinfo*)
104104
# Move libtinfo libraries to a custom path to ensure it is not
105105
# unintentionally used in downstream images.
106-
find ./usr/lib/${arch}-linux-gnu -type f |
106+
find ./usr/lib/"${arch}"-linux-gnu -type f |
107107
{
108-
while read binary; do
108+
while read -r binary; do
109109
add_rpath "${binary}" "/lib/${arch}-linux-gnu/terminfo"
110110
done
111111
}
112112

113-
mv ./lib/${arch}-linux-gnu ./temp
114-
mkdir ./lib/${arch}-linux-gnu
115-
mv ./temp ./lib/${arch}-linux-gnu/terminfo
113+
mv ./lib/"${arch}"-linux-gnu ./temp
114+
mkdir ./lib/"${arch}"-linux-gnu
115+
mv ./temp ./lib/"${arch}"-linux-gnu/terminfo
116116

117-
mv ./usr/lib/${arch}-linux-gnu ./temp
118-
mkdir ./usr/lib/${arch}-linux-gnu
119-
mv ./temp ./usr/lib/${arch}-linux-gnu/terminfo
117+
mv ./usr/lib/"${arch}"-linux-gnu ./temp
118+
mkdir ./usr/lib/"${arch}"-linux-gnu
119+
mv ./temp ./usr/lib/"${arch}"-linux-gnu/terminfo
120120
;;
121121
base-passwd)
122122
# The dependencies libdebconfclient0 (and libselinux1 for Debian>=12)

images/create-env/install-conda

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ miniconda_boostrap_prefix="$(pwd)/miniconda"
1010

1111
# Use the base image-provided tools if they work for us:
1212
tools=''
13-
find -print0 -maxdepth 0 && xargs -0 true </dev/null ||
13+
find . -maxdepth 0 -print0 && xargs -0 true </dev/null ||
1414
tools="${tools} findutils"
1515
sed -e '' </dev/null ||
1616
tools="${tools} sed"

0 commit comments

Comments
 (0)