Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simpleaf to 0.18.0 #52979

Merged
merged 5 commits into from
Dec 24, 2024
Merged

Update simpleaf to 0.18.0 #52979

merged 5 commits into from
Dec 24, 2024

Conversation

BiocondaBot
Copy link
Collaborator

Update simpleaf: 0.17.4 → 0.18.0

install with bioconda Conda

Info Link or Description
Recipe recipes/simpleaf (click to view/edit other files)
Summary A rust framework to make using alevin-fry even simpler.
Home https://github.com/COMBINE-lab/simpleaf
Releases https://github.com/COMBINE-lab/simpleaf/tags
Author @COMBINE-lab

This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Dec 24, 2024
@rob-p
Copy link
Contributor

rob-p commented Dec 24, 2024

It’s trying to build salmon from source on osx-arm64 and I have no idea why. It shouldn’t do this and, in fact, we can just skip the salmon dependency on osx-arm64. Any idea why the annotation isn’t working?

@rob-p rob-p enabled auto-merge (squash) December 24, 2024 17:42
rob-p
rob-p approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@rob-p rob-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I had to disable salmon on OS-X because the build wouldn’t understand the annotation # [not osx-arm64]. This isn’t ideal, but I guess the user can manually install on OSX-64. Anyway, we should figure out how to only disable the salmon dep on osx-arm64.

@rob-p rob-p merged commit ea9e161 into master Dec 24, 2024
5 checks passed
@rob-p rob-p deleted the bump/simpleaf branch December 24, 2024 17:44
@rob-p rob-p restored the bump/simpleaf branch December 25, 2024 05:58
@rob-p rob-p deleted the bump/simpleaf branch December 25, 2024 06:00
@martin-g
Copy link
Contributor

'# [not osx and not arm64]'
or even simpler: '# [not arm64]'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-p rob-p rob-p approved these changes

Assignees
No one assigned
Labels
autobump Automatic Version Update new version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BiocondaBot @rob-p @martin-g