Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for scArches #50636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jdblischak
Copy link
Member

https://github.com/theislab/scarches
https://pypi.org/project/scArches/


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jdblischak
Copy link
Member Author

Main downside is that this package is quite large:

https://pypi.org/project/scArches/#files

image

@jdblischak
Copy link
Member Author

FYI @theislab, please let me know if any of the scArches developers would like to be added as maintainers of the bioconda recipe

@jdblischak
Copy link
Member Author

The pip check test failed:

scvi-tools 1.1.6 has requirement lightning<2.2,>=2.0, but you have lightning 2.4.0.

@jdblischak
Copy link
Member Author

Unclear where this upper bound is coming from

The upstream package dropped the upper bound 5 months ago

scverse/scvi-tools@9b4277f
scverse/scvi-tools#2751

And the feedstock dropped the upper bound 2 weeks ago

conda-forge/scvi-tools-feedstock#52

The bioconda build installed the latest scvi-tools 1.1.6-pyhd8ed1ab_1

https://anaconda.org/conda-forge/scvi-tools/files?version=1.1.6

Which has a correct recipe, but the lightning<2.2 is still buried in the METADATA:

wget https://anaconda.org/conda-forge/scvi-tools/1.1.6/download/noarch/scvi-tools-1.1.6-pyhd8ed1ab_1.conda
cph extract scvi-tools-1.1.6-pyhd8ed1ab_1.conda
grep lightning scvi-tools-1.1.6-pyhd8ed1ab_1/info/recipe/meta.yaml
##     - lightning >=2.0
grep -R lightning scvi-tools-1.1.6-pyhd8ed1ab_1/site-packages/scvi_tools-1.1.6.dist-info/
## scvi-tools-1.1.6-pyhd8ed1ab_1/site-packages/scvi_tools-1.1.6.dist-info/METADATA:Requires-Dist: lightning<2.2,>=2.0
## scvi-tools-1.1.6-pyhd8ed1ab_1/site-packages/scvi_tools-1.1.6.dist-info/METADATA:Lightning](https://www.pytorclightning.ai/) and

@jdblischak
Copy link
Member Author

Now running into conda-forge/scvi-tools-feedstock#57 (comment)

 scvi-tools 1.1.6.post2 has requirement anndata<=0.10.8,>=0.7.5, but you have anndata 0.10.9.

@jdblischak
Copy link
Member Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Sep 18, 2024
@jdblischak
Copy link
Member Author

I rebased my PR onto master. Here is the passing Azure build from yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants