Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage installation does not build with PyPa #174

Open
ayush9pandey opened this issue Jul 12, 2024 · 3 comments
Open

Lineage installation does not build with PyPa #174

ayush9pandey opened this issue Jul 12, 2024 · 3 comments
Assignees
Labels
Bioscrape Core Issues pertaining to core bioscrape functionality bug Something isn't working Lineages Issues pertaining to bioscrape lineages

Comments

@ayush9pandey
Copy link
Collaborator

With new Python v3.12 compatibility in Bioscrape and changes to the Python build process for PyPi release (the recommended way is through: https://build.pypa.io/en/latest/), the command python -m build throws an error in lineage installation.

Suggested fix: Set up such that pip install bioscrape only installs bioscrape core without lineage. For users who need lineage, the direct installation method would still work with python setup.py install lineage after cloning the repository.

An alternate (ideal) fix: Set up the build process such that lineage is also built and packaged in the distribution.

@ayush9pandey ayush9pandey added bug Something isn't working Bioscrape Core Issues pertaining to core bioscrape functionality Lineages Issues pertaining to bioscrape lineages labels Jul 12, 2024
@ayush9pandey ayush9pandey self-assigned this Jul 12, 2024
@WilliamIX
Copy link
Collaborator

@ayush9pandey what is the lineage error? Maybe this can be fixed.

@ayush9pandey
Copy link
Collaborator Author

Here's the error: https://github.com/biocircuits/bioscrape/actions/runs/9904679317/job/27362599090

you can also re-create it by setting up a py 3.12 environment and running python -m build

It would be great if it could be fixed.

@WilliamIX
Copy link
Collaborator

@ayush9pandey I suspect this issue is to do with Python moving away from setup.py in newer versions. It looks like cython is expecting every import to be a separate file. I can look into this further in August (next couple of weeks are a swamp). It's interesting that Bioscrape core installs but Lineages doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bioscrape Core Issues pertaining to core bioscrape functionality bug Something isn't working Lineages Issues pertaining to bioscrape lineages
Projects
None yet
Development

No branches or pull requests

2 participants