Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bincrafters-conventions: detect for CCI-like repos which recipes+versions do NOT have open PRs #1325

Open
Croydon opened this issue Dec 17, 2020 · 3 comments

Comments

@Croydon
Copy link
Member

Croydon commented Dec 17, 2020

More automation should not mean more work for humans.

I would like to get to the point, that bincrafters-conventions is automatically creating PRs for convention updates.

However, several updates could cause a need of rebasing in existing PRs. Hence I would like to let the bot only create automatic PRs for recipes in versioned recipe folders, which do not have currently PRs open against them.

What is the easiest way to assembly a list of paths that are getting changed in ALL opened PRs?

Is there an easier trick than iterating over all PRs, checking them all out via git and literally going over all file changes?

@ericLemanissier
Copy link
Contributor

There may be another way, but that's how I did it https://github.com/ericLemanissier/conan-center-conflicting-prs/blob/main/main.py#L30-L58

@Croydon
Copy link
Member Author

Croydon commented Dec 17, 2020

Thanks! That looks good

@ericLemanissier
Copy link
Contributor

My parsing of diffs is too rudimentary, I should use unidiff instead, but did not have the time to go through it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants