Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to disable rust-analyzer sever path override #42

Open
flxzt opened this issue Oct 30, 2021 · 4 comments
Open

Setting to disable rust-analyzer sever path override #42

flxzt opened this issue Oct 30, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@flxzt
Copy link

flxzt commented Oct 30, 2021

Sometimes rust-analyzer stops working when the server path is overridden by flatpak-vscode.

One cause is this issue, where the only solution that I know of is to disable rust-analyzer completely to stop it from consuming resources, or to disable flatpak-vscode and delete that override so that rust-analyzer can run on the host ( where it does not hang for me)

But there is also the issue that sometimes rust-analyzer does not start by itself, the only solution I have found that I need to build or run the flatpak at least once and restart vscode.

I think a setting to disable the server path override would be very useful, so that rust-analyzer could run on the host if wanted.

I already have the implementation ready, but I think somebody who actually knows typescript should take a second look at it.
Tell me if this sounds reasonable and I would open a PR.
Thanks!

@flxzt flxzt changed the title Enhancement: settings to disable rust-analyzer sever path override Enhancement: setting to disable rust-analyzer sever path override Oct 30, 2021
@bilelmoussaoui
Copy link
Owner

Do you mind opening a PR? I will have a look at your changes and see if we can easily integrate it to the rest of the extension

@bilelmoussaoui
Copy link
Owner

I think I fixed the issue of rust-analyzer stopping working, do you mind removing your .flatpak, updating the extension & trying again?

@flxzt
Copy link
Author

flxzt commented Jan 5, 2022

I think the issue of rust analyzer getting stuck in the dir is solved. I do have some other issues with flatpak (e.g. document portal not starting after reboot), so rust analyzer still fails sometimes when having set the path override. I would still like to update the PR to the lastest version and make it ready for merging (if I am able to and you are willing to merge), but the code on github is outdated (v0.15 instead of v0.16). Could you push to v0.16? Thanks!

@bilelmoussaoui
Copy link
Owner

Oh sorry, I thought i pushed! Done. Yes I would still like to merge your PR, i was just wondering how to properly fix the root of the issue instead of working around it

@bilelmoussaoui bilelmoussaoui changed the title Enhancement: setting to disable rust-analyzer sever path override Setting to disable rust-analyzer sever path override Apr 16, 2023
@bilelmoussaoui bilelmoussaoui added the enhancement New feature or request label Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants