Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out the project source entry #129

Open
bilelmoussaoui opened this issue Mar 3, 2022 · 4 comments · May be fixed by #183 or #141
Open

Figure out the project source entry #129

bilelmoussaoui opened this issue Mar 3, 2022 · 4 comments · May be fixed by #183 or #141
Labels
enhancement New feature or request

Comments

@bilelmoussaoui
Copy link
Owner

bilelmoussaoui commented Mar 3, 2022

If you clone ashpd and open it with vscode, it will properly find the ashpd-demo manifest but won't build because the meson.build won't be found in this case as it is in ashpd-demo subdirectory.

I think we should look at the last module, if it is of type path, get the absolute path based on that + the path of the manifest. If it is not, we need to come up with a different approach.

@SeaDve
Copy link
Collaborator

SeaDve commented Mar 6, 2022

I think gnome-builder also has the same issue? I have had trouble building ashpd-demo not founding the meson.build file with gnome-builder.

@bilelmoussaoui
Copy link
Owner Author

It was fixed in nightly a couple of weeks ago

@SeaDve
Copy link
Collaborator

SeaDve commented Mar 6, 2022

May you link the commit or the PR

@bilelmoussaoui
Copy link
Owner Author

That is the commit that fixes the issue on builder https://gitlab.gnome.org/GNOME/gnome-builder/-/commit/dabde58

@SeaDve SeaDve linked a pull request Mar 10, 2022 that will close this issue
3 tasks
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
@SeaDve SeaDve linked a pull request Aug 2, 2022 that will close this issue
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 2, 2022
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Aug 3, 2022
@bilelmoussaoui bilelmoussaoui added the enhancement New feature or request label Apr 6, 2023
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Apr 17, 2023
SeaDve added a commit to SeaDve/flatpak-vscode that referenced this issue Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants