Handle situation where user changes manifest while they have active build/runtime terminals

[SeaDve]

See #94 review comments

[bilelmoussaoui]

I think we could display the used SDK versions for those terminals on their title if possible?

[bilelmoussaoui]

It doesn't handle the situation at all but at least it is clear in case you are using two manifests with one on stable/other on nightly runtime

[SeaDve]

I think we could display the used SDK versions for those terminals on their title if possible?

I have been thinking about that too. That's possible, but we again have long naming issues :(

What about <runtime> <runtime-version> for runtime (e.g. Flatpak: org.gnome.Platform 41 Terminal) and <AppId> Build for build (e.g. Flatpak: org.some.App Build Terminal)

We could also maybe emit the Flatpak: prefix as we already have the package icon

[bilelmoussaoui]

I would go with Flatpak: org.gnome.Platform//41 for runtime terminal, Flatpak: org.gnome.App for build terminal

[SeaDve]

Won't Flatpak: org.gnome.App be confused with something that was run with flatpak run --comand=sh <AppId>

[bilelmoussaoui]

Won't Flatpak: org.gnome.App be confused with something that was run with flatpak run --comand=sh <AppId>

that is what the build terminal do :) it just adds the finish-args and passes --devel as well

[SeaDve]

ohhhhh, good to know

[bilelmoussaoui]

Both running the app and the build terminal go through the runInRepo function, with different commands to run

[SeaDve]

The Flatpak: prefix kinda feels repetitive for me (at least when they are opened consecutively)

[SeaDve]

The labels are also somehow lost after a restart

[bilelmoussaoui]

image
The Flatpak: prefix kinda feels repetitive for me (at least when they are opened consecutively)

Maybe we could drop the prefix, can we have tooltips there though?

[bilelmoussaoui]

The labels are also somehow lost after a restart

Maybe there is some kind of event to register for, for the created terminals so we can restore them properly? or maybe even just opt-out of the restore if possible...

[SeaDve]

Maybe we could drop the prefix, can we have tooltips there though?

Oddly, there seems none. Tooltips only replicates the name

[SeaDve]

API for opting out for restoring is currently on testing