Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gen 5 species set #19

Open
jay816314 opened this issue Dec 25, 2019 · 5 comments
Open

Adding gen 5 species set #19

jay816314 opened this issue Dec 25, 2019 · 5 comments

Comments

@jay816314
Copy link

Sorry for bothering you.

I have some problem while i'm trying to add gen5 speicies set. I can't find the specific steps to add species set in the documentation. So i did the following things according to the document.

  1. edit the pack.ini in /themes/species folder, add
    `[range|5]

range_start = 494
range_end = 649
vector = "{%variant%}/vector/gen5/{%n%}.svg"
raster = "{%variant%}/raster/gen5/{%n%}.png"
`
2. add gen5 folder in each vector and raster folder. add png and svg files.

3.add gen5 id in i18n/speices.po

But i get the erroruncaught typeerror: cannot read property 'hasOwnProperty' of null in line 395 of main.js when i using gen5 id as encounter_species's id.

I don't know what else should i do. Thanks!

@ghost
Copy link

ghost commented Jan 5, 2020

By doing some research in the files.

I found out that on \includes\lib\research.php, at the Line 210.
There's an array with the number of the last mon of each generation, as 493 is the last one of gen4, you should add 649.

Let me know if that solves the problem because I will have to do the same later, after I finish with some small details until I launch the map for my community.

image

@bilde2910
Copy link
Owner

Apologies for the delay, I've been a bit busy. @Ayztal's solution is correct. The pokédex number of the last Pokémon in gen V, 649, should be appended to the GENERATIONS_HIGHEST array. In addition, icons for gen V must be added and declared, and Pokémon names must be added to i18n/species.po. That should be all that is required to add gen V support.

I have not had the time or motivation to work on FreeField lately, though if there's still interest, I can try to push some updates so that we're at least á jour with the latest field research tasks. (If there's a good list out there.)

@jay816314
Copy link
Author

By doing some research in the files.

I found out that on \includes\lib\research.php, at the Line 210.
There's an array with the number of the last mon of each generation, as 493 is the last one of gen4, you should add 649.

Let me know if that solves the problem because I will have to do the same later, after I finish with some small details until I launch the map for my community.

image

Thanks a lot! It did work.
So the rest job i need to do is trying to make gen V icons...

@jay816314
Copy link
Author

Apologies for the delay, I've been a bit busy. @Ayztal's solution is correct. The pokédex number of the last Pokémon in gen V, 649, should be appended to the GENERATIONS_HIGHEST array. In addition, icons for gen V must be added and declared, and Pokémon names must be added to i18n/species.po. That should be all that is required to add gen V support.

I have not had the time or motivation to work on FreeField lately, though if there's still interest, I can try to push some updates so that we're at least á jour with the latest field research tasks. (If there's a good list out there.)

Thanks!It actually worked.

The job of updating research tasks is not very urgent. Gen V pokemon will be released frequently in these months, and the tasks will also change frequently. If you're busy, you can focus on your job first. Thanks for your kindness.

@bilde2910
Copy link
Owner

So the rest job i need to do is trying to make gen V icons...

I have a script that can do this. I'll need to take a look at the Pokémon in question and try to come up with proper colors etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants