From 7a82257838aef84fc67bb4e1205c5f05672b5ac1 Mon Sep 17 00:00:00 2001 From: "Andrew A. Barber" Date: Mon, 4 Nov 2024 13:20:28 +0000 Subject: [PATCH 1/2] refactor: optimize image source concatenation for payment method icons --- templates/components/account/payment-methods-list.html | 2 +- templates/pages/account/add-payment-method.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/components/account/payment-methods-list.html b/templates/components/account/payment-methods-list.html index 3a841d9ff4..44049a25d6 100644 --- a/templates/components/account/payment-methods-list.html +++ b/templates/components/account/payment-methods-list.html @@ -21,7 +21,7 @@

{{!-- If credit card STARTS --}} {{#if brand}} {{#inArray ../../theme_settings.supported_card_type_icons brand }} - {{lang (concat 'account.payment_methods.card_types.' brand)}} + {{lang (concat 'account.payment_methods.card_types.' brand)}} {{/inArray}} {{lang (concat 'account.payment_methods.card_types.' brand)}} {{lang 'account.payment_methods.card_ending_in' last_four=last_4}} {{else}} diff --git a/templates/pages/account/add-payment-method.html b/templates/pages/account/add-payment-method.html index 6d0a007360..4158a02a0c 100644 --- a/templates/pages/account/add-payment-method.html +++ b/templates/pages/account/add-payment-method.html @@ -59,7 +59,7 @@

{{lang 'account.payment_methods.payment_me {{forms.payment_method.provider_name}} {{#each ../theme_settings.supported_card_type_icons}} - {{lang (concat 'account.payment_methods.card_types.' this)}} + {{lang (concat 'account.payment_methods.card_types.' this)}} {{/each}}

From c6a5df835962fefa9a6fc2a59cc7e66edcf0c07c Mon Sep 17 00:00:00 2001 From: "Andrew A. Barber" Date: Mon, 4 Nov 2024 13:22:13 +0000 Subject: [PATCH 2/2] refactor: simplify concat logic using multiConcat handlebar helper --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6afa13b72d..8ac1e2bc84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix GH build action & added package version and short commit hash to artifact names in GitHub Actions workflow for improved traceability and uniqueness. ([#2494](https://github.com/bigcommerce/cornerstone/pull/2494)) - Bump stencil-utils to 6.18.0 ([#2493](https://github.com/bigcommerce/cornerstone/pull/2493)) - Bump other GH actions to fix warnings related to old versions. ([#2495](https://github.com/bigcommerce/cornerstone/pull/2495)) +- Refactored complex `concat` logic to use `multiConcat` handlebar helper. ([2507](https://github.com/bigcommerce/cornerstone/pull/2507)) ## 6.15.0 (10-18-2024) - Cornerstone changes to support inc/ex tax price lists on PDP [#2486](https://github.com/bigcommerce/cornerstone/pull/2486)