Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product ID data type changed? #2504

Open
amfischer opened this issue Oct 31, 2024 · 1 comment
Open

Product ID data type changed? #2504

amfischer opened this issue Oct 31, 2024 · 1 comment

Comments

@amfischer
Copy link

Hello,

We recently had code break that was previously working and I wonder if there was a recent change to the incoming handlebars data.

We have template code like this throughout our theme

{{#if product.id '===' '115'}}
  ...
{{/if}}

And this no longer works. We now have to use either double equals '==' or check the product id against a number value instead of a string value.

It's not a big issue to update this code but it was a surprise when our site stop rendering correctly. Was this a recent change to the incoming data? And if so is there somewhere we can read about or monitor for upcoming changes?

@arosesiejdev
Copy link

Noticed this as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants