Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] channels and events files do not accept desc for derivative datastest #2029

Open
neuromechanist opened this issue Jan 15, 2025 · 0 comments · May be fixed by #2043
Open

[BUG] channels and events files do not accept desc for derivative datastest #2029

neuromechanist opened this issue Jan 15, 2025 · 0 comments · May be fixed by #2043
Labels
bug Something isn't working

Comments

@neuromechanist
Copy link
Member

neuromechanist commented Jan 15, 2025

Describe your problem in detail.

Created a BIDS derivative dataset with _desc to indicate what has been changed. The new BIDS validator throws an error for channels, events, and subsequently, electodes and coordsystem as they can't accept `desc'.

Example log:

/sub-NDARAC904DMU/eeg/sub-NDARAC904DMU_task-contrastChangeDetection_run-1_desc-dataElectrodes_channels.tsv (desc not in rule rules.files.raw.channels.channels)
/sub-NDARAC904DMU/eeg/sub-NDARAC904DMU_task-contrastChangeDetection_run-1_desc-dataElectrodes_events.tsv (desc not in rule rules.files.raw.task.events)
/sub-NDARAC904DMU/eeg/sub-NDARAC904DMU_task-contrastChangeDetection_run-2_desc-dataElectrodes_channels.tsv (desc not in rule rules.files.raw.channels.channels)
/sub-NDARAC904DMU/eeg/sub-NDARAC904DMU_task-contrastChangeDetection_run-2_desc-dataElectrodes_events.tsv (desc not in rule rules.files.raw.task.events)

I have already set "DatasetType": "derivative", and the lack of the same error for eeg files indicates that the problem is isolated to events and channels.

Describe what you expected.

All files should accept the desc entity as they all could be updated in a derivative dataset.

BIDS specification section

The reason seems to stem from the lack of explicit mention of these file types under src/schema/rules/files/deriv/preprocessed_data.yaml.

cc:@arnodelorme

@neuromechanist neuromechanist added the bug Something isn't working label Jan 15, 2025
@neuromechanist neuromechanist linked a pull request Feb 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant