Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ASLTotalAcquiredPairsASLContextLength check is incorrect #1975

Open
tsalo opened this issue Nov 3, 2024 · 1 comment
Open

[BUG] ASLTotalAcquiredPairsASLContextLength check is incorrect #1975

tsalo opened this issue Nov 3, 2024 · 1 comment
Labels
bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release.

Comments

@tsalo
Copy link
Member

tsalo commented Nov 3, 2024

Describe your problem in detail.

TotalAcquiredPairs is compared against the number of rows in aslcontext, but the TotalAcquiredPairs value should be the number of control-label pairs, while the aslcontext file should have one row for each volume.

Describe what you expected.

I think the check should be that TotalAcquiredPairs is <= the number of rows in the aslcontext file, since at most the aslcontext file could have 2x the number of pairs, if all of the volumes in the file as control or label volumes, but at minimum there could just be a single pair with a bunch of m0scan, deltam, and/or cbf volumes filling out the rest of the asl file.

BIDS specification section

ASLTotalAcquiredPairsASLContextLength:
issue:
code: TOTAL_ACQUIRED_VOLUMES_NOT_CONSISTENT
message: |
The number of values for 'TotalAcquiredPairs' for this file does not match number of
volumes in the associated 'aslcontext.tsv'.
'TotalAcquiredPairs' is the original number of 3D volumes acquired for each volume defined in the
associated 'aslcontext.tsv'.
level: warning
selectors:
- suffix == "asl"
- type(associations.aslcontext) != "null"
- '"TotalAcquiredPairs" in sidecar'
checks:
- aslcontext.n_rows == sidecar.TotalAcquiredPairs

@tsalo tsalo added bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release. labels Nov 3, 2024
@effigies
Copy link
Collaborator

effigies commented Nov 3, 2024

Yeah, the check should either be a bound or we could count pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

No branches or pull requests

2 participants