Skip to content

Commit 315c08f

Browse files
yarikopticeffigies
authored andcommitted
Rename "project" to "study"
While discussing with @jbpoline we wondered, if may be `study` would be a better descriptor to use here in favor of `project`. One of the rationales, is that e.g. in [BEP035](https://bids.neuroimaging.io/extensions/beps/bep_035.html) (attn @bids-standard/bep035) on Mega-analysis they introduce `study-` entity as a groupping element. It kinda then would match natively. we also mention "study" in various places in BIDS which seems to align nicely here ```shell ❯ git grep study src/CHANGES.md:- \[FIX] update physio bids name in longitudinal study page examples [#863](#863) ([Remi-Gau](https://github.com/Remi-Gau)) src/appendices/coordinate-systems.md:The following template identifiers are RECOMMENDED for individual- and study-specific reference src/appendices/coordinate-systems.md:In the case of multiple study templates, additional names may need to be defined. src/appendices/coordinate-systems.md:| study | Custom space defined using a group/study-specific template. This coordinate system requires specifying an additional file to be fully defined. | src/appendices/hed.md:numerical values that are similar across the recordings in the study. src/appendices/hed.md:repository on GitHub should be used to validate the study event annotations. src/common-principles.md: unless when appropriate given the study goals, for example, when scanning babies. src/introduction.md:> The data used in the study were organized using the src/modality-specific-files/genetic-descriptor.md: "Dataset": "https://www.ncbi.nlm.nih.gov/projects/gap/cgi-bin/study.cgi?study_id=phs001364.v1.p1", src/modality-specific-files/intracranial-electroencephalography.md:Note that the date and time information SHOULD be stored in the study key file src/modality-specific-files/magnetic-resonance-spectroscopy.md:acquisition parameters in filenames is helpful or necessary to distinguish datasets in a given study. src/modality-specific-files/motion.md:Note that the onsets of the recordings SHOULD be stored in the study key file [(`scans.tsv`)](../modality-agnostic-files.md#scans-file). src/modality-specific-files/positron-emission-tomography.md:This entity is OPTIONAL if only one tracer is used in the study, src/modality-specific-files/task-events.md:Please mind that this does not imply that only so called "event related" study designs src/schema/objects/common_principles.yaml: A set of neuroimaging and behavioral data acquired for a purpose of a particular study. src/schema/objects/common_principles.yaml: Session can (but doesn't have to) be synonymous to a visit in a longitudinal study. src/schema/objects/common_principles.yaml: A person or animal participating in the study. src/schema/objects/entities.yaml: For example, this should be used when a study includes two T1w images - src/schema/objects/entities.yaml: Session can (but doesn't have to) be synonymous to a visit in a longitudinal study. src/schema/objects/entities.yaml: A person or animal participating in the study. src/schema/objects/enums.yaml:study: src/schema/objects/enums.yaml: value: study src/schema/objects/enums.yaml: display_name: study src/schema/objects/enums.yaml: Custom space defined using a group/study-specific template. src/schema/objects/metadata.yaml: Reference to the study/studies on which the implementation is based. src/schema/objects/metadata.yaml: The version of the HED schema used to validate HED tags for study. tools/schemacode/src/bidsschematools/tests/data/broken_dataset_description.json:"EthicsApprovals": ["The original study from which this BIDS example dataset was derived was approved by the Ethics committee of Ghent University Hospital with identifier EC 2017/1103."] ``` and "project" mentionings are not particularly aligned. So, I think, we should just make it a "study", hence renaming accordingly.
1 parent adfcc79 commit 315c08f

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

src/common-principles.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -400,17 +400,17 @@ In particular, if a BIDS dataset contains a `derivatives/` subdirectory,
400400
the contents of that directory may be a heterogeneous mix of BIDS Derivatives
401401
datasets and non-compliant derivatives.
402402
403-
## Project dataset
403+
## Study dataset
404404
405-
BIDS allows one to organize the data for the entire project (original source data, raw BIDS, derivatives) as a valid BIDS dataset in the following way
405+
BIDS allows one to organize the data for the entire study (original source data, raw BIDS, derivatives) as a valid BIDS dataset in the following way
406406
407407
<!-- This block generates a file tree.
408408
A guide for using macros can be found at
409409
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
410410
-->
411411
{{ MACROS___make_filetree_example(
412412
{
413-
"my_project-1": {
413+
"study-1": {
414414
"sourcedata": {
415415
"dicoms": {},
416416
"raw": {
@@ -438,7 +438,7 @@ In this example, `sourcedata/dicoms` is not nested inside
438438
The subdirectories of `derivatives` MAY be BIDS-compliant derivatives datasets
439439
(see [Non-compliant derivatives](#non-compliant-derivatives) for further discussion).
440440
The above example is a fully compliant BIDS dataset, providing a convention useful for organizing source, raw BIDS, and derived BIDS data while maintaining overall BIDS compliance.
441-
When using this convention, `dataset_description.json` MUST have `DatasetType` to be set to `"project"`. It is also RECOMMENDED to set the `SourceDatasets`
441+
When using this convention, `dataset_description.json` MUST have `DatasetType` to be set to `"study"`. It is also RECOMMENDED to set the `SourceDatasets`
442442
field in `dataset_description.json` of each subdirectory of `derivatives` to:
443443
444444
```JSON

src/schema/objects/enums.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -360,14 +360,19 @@ individual:
360360
In context of surfaces this space has been referred to as `fsnative`.
361361
362362
In order for this space to be interpretable, `SpatialReference` metadata MUST be provided.
363-
study:
363+
study__space:
364364
value: study
365365
display_name: study
366366
description: |
367367
Custom space defined using a group/study-specific template.
368368
This coordinate system requires specifying an additional file to be fully defined.
369369
370370
In order for this space to be interpretable, `SpatialReference` metadata MUST be provided.
371+
study__datasettype:
372+
value: study
373+
display_name: study
374+
description: |
375+
A study BIDS dataset.
371376
scanner:
372377
value: scanner
373378
display_name: scanner
@@ -1319,11 +1324,6 @@ derivative:
13191324
display_name: derivative
13201325
description: |
13211326
A derived BIDS dataset.
1322-
project:
1323-
value: project
1324-
display_name: project
1325-
description: |
1326-
A project BIDS dataset.
13271327
balanced:
13281328
value: balanced
13291329
display_name: balanced

src/schema/objects/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ DatasetType:
583583
enum:
584584
- $ref: objects.enums.raw.value
585585
- $ref: objects.enums.derivative.value
586-
- $ref: objects.enums.project.value
586+
- $ref: objects.enums.study__datasetype.value
587587
DecayCorrectionFactor:
588588
name: DecayCorrectionFactor
589589
display_name: Decay Correction Factor

src/schema/rules/checks/dataset.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ NoSubjectFolders:
1818
issue:
1919
code: NOSUBJECT_FOLDERS
2020
message: |
21-
There should be no subject directories (labeled "sub-*") in the root of this project BIDS dataset.
21+
There should be no subject directories (labeled "sub-*") in the root of this study BIDS dataset.
2222
level: warning
2323
selectors:
2424
- path == '/dataset_description.json'
25-
- dataset.dataset_description.DatasetType == "project"
25+
- dataset.dataset_description.DatasetType == "study"
2626
checks:
2727
- length(dataset.subjects.sub_dirs) == 0
2828

0 commit comments

Comments
 (0)