Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit test for dataset without session level #89

Closed
Remi-Gau opened this issue Dec 19, 2023 · 3 comments
Closed

Add explicit test for dataset without session level #89

Remi-Gau opened this issue Dec 19, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists low priority
Milestone

Comments

@Remi-Gau
Copy link
Collaborator

Mostly as a sanity check as I have seen a lot of bids apps struggling to handle both of those cases.

Should be possible to use nilearn internals to mock fmriprep datasets as the test dataset only cover one of those.

@htwangtw htwangtw added this to the JOSS submission milestone Mar 25, 2024
@htwangtw
Copy link
Collaborator

Right now the test dataset has session but internally we have run several datasets without the session level at this point and the problem is solved. We can add an explicit test for this later.

@htwangtw htwangtw removed this from the JOSS submission milestone Mar 25, 2024
@Remi-Gau
Copy link
Collaborator Author

okidoki!!

@htwangtw htwangtw changed the title Make sure files can be found in datasets with and without a session level folder Add explicit test for dataset without session level Mar 25, 2024
@htwangtw htwangtw added this to the Next update milestone Jun 3, 2024
@htwangtw
Copy link
Collaborator

htwangtw commented Jun 3, 2024

This will be addressed by adding ds000228 and it will address more issues beyond the session label. I will close this one in favour of #151!

@htwangtw htwangtw closed this as completed Jun 3, 2024
@htwangtw htwangtw added the duplicate This issue or pull request already exists label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists low priority
Projects
None yet
Development

No branches or pull requests

2 participants