Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filterwarnings = ["error"] triggered a some improvements needed #82

Open
htwangtw opened this issue Dec 14, 2023 · 1 comment
Open

filterwarnings = ["error"] triggered a some improvements needed #82

htwangtw opened this issue Dec 14, 2023 · 1 comment

Comments

@htwangtw
Copy link
Collaborator

          okay adding those extra options has raised some issues and revealed some very hacky things I did for good - 
  • test_load_atlas_setting, test_generate_group_mask: i manually override the templateflow home to load customised atlas. this is not a typical use case of templateflow
  • test_calculate_intranetwork_correlation: we used the niftimasker to flatten label atlas (3D); solvable
  • test_get_bids_images: this is from a hack to force pybids to index fmriprep outputs, you are a better person to judge if i am doing the right thing here

Originally posted by @htwangtw in #58 (comment)

After the above issues are fixed, filterwarnings = ["error"] should be add to the pytest config

@htwangtw
Copy link
Collaborator Author

This will trigger a lot of upstream projects with deprecation warnings. Skip for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant