-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
figwheel-sidecar breaks :websocket-host #683
Comments
I don't completely understand the situation you are describing here. How are you starting figwheel? Is the :websocket-host figwheel config changing? and more specifically what specific thing is causing it to change? |
Ok, I updated my initial text for clarity. The problem is that the value of the The config syntax itself is still validated though: when I move the param to an invalid block, I get the expected error message, but as soon as I set it in the valid place, it is just ignored. FYI: I start it using When I remove the My (defproject
foo/bar "1.0.0"
:license "Proprietary"
:url "https://www.foo.bar
:dependencies [[org.clojure/clojure "1.9.0"]
[org.clojure/clojurescript "1.10.238"]
; Fix conflicts on 'lein deps'
[org.clojure/tools.nrepl "0.2.13"]
[reagent "0.8.0-rc1" :exclusions [cljsjs/react cljsjs/react-dom]]
[cljsjs/react "16.3.0-1"]
[cljsjs/react-dom "16.3.0-1"]
[binaryage/oops "0.5.8"]
[prismatic/schema "1.1.9"]
[frankiesardo/linked "1.3.0"]]
:pedantic? :abort
:clean-targets ^{:protect false} ["target" "resources/public/js/" "resources/private/js/"]
:plugins [[lein-cljsbuild "1.1.7"]
[lein-figwheel "0.5.16-SNAPSHOT" :exclusions [org.clojure/clojure]]]
:profiles {:dev {:source-paths ["src" "dev"]
:dependencies [[binaryage/devtools "0.9.10"]
[cider/piggieback "0.3.1"]
[figwheel-sidecar "0.5.16-SNAPSHOT"]
[devcards "0.2.5-SNAPSHOT"]]}}
:repl-options {:nrepl-middleware [cider.piggieback/wrap-cljs-repl]}
:figwheel {:css-dirs ["resources/public/css"]}
:cljsbuild {:builds [{:id "dev"
:source-paths ["src"]
:compiler {:main app.core
:asset-path "/js/compiled/frontend/out"
:output-to "resources/public/js/compiled/frontend.js"
:output-dir "resources/public/js/compiled/frontend/out"
:optimizations :none
:recompile-dependents false
:parallel-build true
:compiler-stats true
:preloads [devtools.preload]}
:figwheel {:websocket-host :js-client-host
:on-jsload "app.core/on-jsload"
:before-jsload "app.core/before-jsload"}}
{:id "devcards"
:source-paths ["src-cards" "src"]
:compiler {:main "cards.start-ui"
:asset-path "js/compiled/cards/out"
:output-to "resources/public/js/compiled/cards.js"
:output-dir "resources/public/js/compiled/cards/out"
:recompile-dependents false
:parallel-build true
:compiler-stats true
:preloads [devtools.preload]}
:figwheel {:devcards true}}]}) |
I can reproduce the bug where I'm also trying to hot-reload my app on a separate device on the network. Browser tabs on the machine where I'm running figwheel hot-reloads fine while on the other device, it does not. |
I can also reproduce this bug, I am trying to run figwheel on chrome in chromeos, using the new linux containers, but changing the |
So I struggled with the same problem, and finally found the cause:
The solution is to do: :compiler {:aot-cache false
,,,} |
@terjedahl Any update on this? Has someone fixed it? |
I have the same problem when running two different builds. I have all configs in my project.clj (didn;t want separate edn files except for some variables i use in dev).
|
Hi,
I noticed that the
:websocket-host
config param is ignored when I loadfigwheel-sidecar
in my (dev) dependencies (and thus the defaultlocalhost
value is used instead of what's in my config).I'm not sure if this a bug or intentional behavior due to some inherent property of sidecar. But even then, some warning in the docs or on runtime could spare people a lot of time :-) If changing the docs is the solution, I'm willing to do a PR.
(FYI: my use case is that I want to run Figwheel from my Cursive REPL (because it has a nicer editor) and hot-reload my app on a smartphone on the local network. I can currently do either of these things separately, but the behavior described above prevents me from doing both at the same time.)
The text was updated successfully, but these errors were encountered: