Skip to content

Add Galaxy wrapper for motus map_snv#1796

Merged
SaimMomin12 merged 4 commits intobgruening:masterfrom
xens25:add-motus-map-snv
Mar 10, 2026
Merged

Add Galaxy wrapper for motus map_snv#1796
SaimMomin12 merged 4 commits intobgruening:masterfrom
xens25:add-motus-map-snv

Conversation

@xens25
Copy link
Contributor

@xens25 xens25 commented Mar 9, 2026

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

There are two labels that allow to ignore specific (false positive) tool linter errors:

  • skip-version-check: Use it if only a subset of the tools has been updated in a suite.
  • skip-url-check: Use it if github CI sees 403 errors, but the URLs work.

@xens25
Copy link
Contributor Author

xens25 commented Mar 9, 2026

Hi @SaimMomin12 . This is the map_snv tool for motus.

Copy link
Collaborator

@SaimMomin12 SaimMomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline

@SaimMomin12
Copy link
Collaborator

SaimMomin12 commented Mar 9, 2026

@xens25 @VERSION_SUFFIX@ and @PROFILE@ needs to be added to macros.xml

@xens25
Copy link
Contributor Author

xens25 commented Mar 9, 2026

@SaimMomin12 After updating the macros, the tests are failing but they pass in the terminal. Did I add something incorrectly?

@SaimMomin12
Copy link
Collaborator

@SaimMomin12 After updating the macros, the tests are failing but they pass in the terminal. Did I add something incorrectly?

@xens25 See here: https://github.com/bgruening/galaxytools/actions/runs/22862161392/job/66366094632?pr=1796

.. WARNING: remote_repository_url may be incorrect: expected it to end with a significant part of '/home/runner/work/galaxytools/galaxytools/tools/motus'

@xens25
Copy link
Contributor Author

xens25 commented Mar 10, 2026

@SaimMomin12 After updating the macros, the tests are failing but they pass in the terminal. Did I add something incorrectly?

@xens25 See here: https://github.com/bgruening/galaxytools/actions/runs/22862161392/job/66366094632?pr=1796

.. WARNING: remote_repository_url may be incorrect: expected it to end with a significant part of '/home/runner/work/galaxytools/galaxytools/tools/motus'

Thanks. After this last update, the test passed. The remaining lint error comes from the motus_profiler.xml which also fails in my terminal. Should I fix that file?

@SaimMomin12
Copy link
Collaborator

SaimMomin12 commented Mar 10, 2026

@SaimMomin12 After updating the macros, the tests are failing but they pass in the terminal. Did I add something incorrectly?

@xens25 See here: https://github.com/bgruening/galaxytools/actions/runs/22862161392/job/66366094632?pr=1796

.. WARNING: remote_repository_url may be incorrect: expected it to end with a significant part of '/home/runner/work/galaxytools/galaxytools/tools/motus'

Thanks. After this last update, the test passed. The remaining lint error comes from the motus_profiler.xml which also fails in my terminal. Should I fix that file?

The remaining linter error is due to unavailability of mgc and bam_no_index datatypes, although they aren't part of the Galaxy Datatypes. We can leave it for now.

@SaimMomin12 SaimMomin12 merged commit b2e3dd2 into bgruening:master Mar 10, 2026
11 of 13 checks passed
@SaimMomin12
Copy link
Collaborator

@bgruening The deployment failed, could you please assist here?

@bgruening
Copy link
Owner

I see this here:

+Linting tool /home/runner/work/galaxytools/galaxytools/tools/motus/motus_profiler.xml
.. ERROR (ValidDatatypes): Unknown datatype [mgc] used in param element
.. ERROR (ValidDatatypes): Unknown datatype [bam_no_index] used in data element

@SaimMomin12
Copy link
Collaborator

I see this here:


+Linting tool /home/runner/work/galaxytools/galaxytools/tools/motus/motus_profiler.xml

.. ERROR (ValidDatatypes): Unknown datatype [mgc] used in param element

.. ERROR (ValidDatatypes): Unknown datatype [bam_no_index] used in data element


Those datatypes do not exist imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants