Skip to content

enable metrics collection #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #38
bjwswang opened this issue Jun 19, 2023 · 5 comments
Open
Tracked by #38

enable metrics collection #40

bjwswang opened this issue Jun 19, 2023 · 5 comments
Assignees
@0xff-dev
Labels
enhancement New feature or request
Milestone
v0.0.1

Comments

@bjwswang
Copy link
Member

bjwswang commented Jun 19, 2023 •
edited
Loading

为更好的监测SaaS服务状态，需要收集一些metrics

  • Counter
    • 用于统计存证的请求总量
      • 失败的数量
      • 成功的数量
  • Histogram
    • 创建存证的响应时间
    • 批次创建存证的响应时间
    • 存证查询的响应时间
    • 通过合约调用查询存证的响应时间
@bjwswang bjwswang mentioned this issue Jun 19, 2023
Open
2 tasks
@bjwswang bjwswang added the enhancement New feature or request label Jun 19, 2023
@bjwswang
Copy link
Member Author

@0xff-dev @Abirdcfly 补充一下

@0xff-dev
Copy link
Collaborator

存证总数量？

@bjwswang
Copy link
Member Author

存证总数量？

用来记录创建存证的总请求数，可以通过记录请求失败数和请求成功数获取总请求数

@Abirdcfly
Copy link
Member

golang 程序通用的metric也可以加上，比如goroutine数量等，方便我们用metrics监控报警。对比pprof适合出问题了查看，但是metrics可以一直采集。

这个应该有库可以直接用。不像上面那些metric需要自己写实现。

@bjwswang
Copy link
Member Author

bjwswang commented Jun 20, 2023 •
edited
Loading

👌那我们先从这两个维度采集metrics. goroutine这块儿主要在处理events

@0xff-dev 还有补充么？

@bjwswang bjwswang modified the milestones: v0.0.2, v0.0.1 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xff-dev 0xff-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.1
Development

No branches or pull requests
3 participants
@Abirdcfly @0xff-dev @bjwswang