Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Theme class to a dataclass #97

Open
foster999 opened this issue May 17, 2020 · 0 comments
Open

Convert Theme class to a dataclass #97

foster999 opened this issue May 17, 2020 · 0 comments
Labels
enhancement ✨ New feature or request investigate 🔍 Needs looking into lower 🟢 M

Comments

@foster999
Copy link
Contributor

foster999 commented May 17, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
The Theme class is very data focused, resulting in lots of attribute boilerplate.

Describe the solution you'd like
Consider using the dataclasses.dataclass decorator to simplify it's implementation.
N.B. this may only be supported in 3.7 onwards
Consider using a similar decorator for GPTheme (maybe attr.s)
@foster999 foster999 added the enhancement ✨ New feature or request label May 17, 2020
@foster999 foster999 added the investigate 🔍 Needs looking into label Jun 11, 2020
@rowanhemsi rowanhemsi added the on hold 🛑 This is not likely to be addressed soon label Jun 27, 2022
@rowanhemsi rowanhemsi added lower 🟢 M and removed on hold 🛑 This is not likely to be addressed soon labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request investigate 🔍 Needs looking into lower 🟢 M
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foster999 @rowanhemsi