Update lintr workflow

Author: Olivia-Box-Power

.github/workflows/lint.yaml

@@ -1,10 +1,13 @@
-name: lint
-
+# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
+# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
 on:
   push:
     branches: [main, master, development]
   pull_request:
-    branches: [main, master, development]
+
+name: lint.yaml
+
+permissions: read-all
 
 jobs:
   lint:
@@ -20,8 +23,11 @@ jobs:
 
       - uses: r-lib/actions/setup-r-dependencies@v2
         with:
-          extra-packages: lintr, local::.
+          extra-packages: any::lintr, local::.
+          needs: lint
 
       - name: Lint
         run: lintr::lint_package()
         shell: Rscript {0}
+        env:
+          LINTR_ERROR_ON_LINT: true

R/use_afcharts.R

@@ -26,8 +26,9 @@
 #' @export
 
 
-use_afcharts <- function(default_colour = afcharts::af_colour_values["dark-blue"],
-                         ...) {
+use_afcharts <- function(
+    default_colour = afcharts::af_colour_values["dark-blue"],
+    ...) {
 
   # Use afcharts theme ----
 
@@ -53,7 +54,7 @@ use_afcharts <- function(default_colour = afcharts::af_colour_values["dark-blue"
 
   # Update default values with those passed to use_afcharts
   new_values <- c(...)
-  for (i in 1:length(new_values)) {
+  for (i in seq_along(new_values)) {
     default <- replace(default,
                        which(names(default) == names(new_values)[i]),
                        new_values[i])