From 7d64de1691228b713c07589daa5770952414c55b Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 2 Feb 2024 13:37:10 -0800 Subject: [PATCH 1/9] try using a test fork of the chp --- hub/values.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hub/values.yaml b/hub/values.yaml index 7c5997a65..13041bee7 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -32,6 +32,15 @@ jupyterhub: service: type: ClusterIP chp: + # testing out a potential fix for the chp leaking ports + # https://github.com/jupyterhub/configurable-http-proxy/issues/434 + # https://github.com/jupyterhub/configurable-http-proxy/issues/434#issuecomment-1924261459 + # https://github.com/http-party/node-http-proxy/pull/1559 + # https://github.com/Jimbly/http-proxy-node16/commit/56283e33edfc7aad8c2605dd493da8a196b4371d + # https://github.com/consideRatio/configurable-http-proxy/commits/main/ + # + image: + tag: 4.6.1-fork resources: requests: # FIXME: We want no guarantees here!!! From 1f50327acccb6d63aa8e9feba3d3441d6d3120e5 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 2 Feb 2024 13:52:01 -0800 Subject: [PATCH 2/9] add timeout and proxytimeout args --- hub/values.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hub/values.yaml b/hub/values.yaml index 13041bee7..b8993078d 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -41,6 +41,9 @@ jupyterhub: # image: tag: 4.6.1-fork + extraCommandLineFlags: + - "--timeout 86400000" + - "--proxyTimeout 86400000" resources: requests: # FIXME: We want no guarantees here!!! From 17dc0c02965dee7e2281cd53ea815fb8d86fdf4b Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 2 Feb 2024 13:54:14 -0800 Subject: [PATCH 3/9] add reference url for reference --- hub/values.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hub/values.yaml b/hub/values.yaml index b8993078d..92a76b06e 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -42,6 +42,8 @@ jupyterhub: image: tag: 4.6.1-fork extraCommandLineFlags: + # set the timeout and proxyTimeout to 24 hours (arg is in milliseconds) + # https://github.com/http-party/node-http-proxy?tab=readme-ov-file#options - "--timeout 86400000" - "--proxyTimeout 86400000" resources: From 858e0c912cf2d59eaf36ea3384b0592e0739bfc0 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 2 Feb 2024 15:57:41 -0800 Subject: [PATCH 4/9] s/ /=/ --- hub/values.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hub/values.yaml b/hub/values.yaml index 92a76b06e..9bc8a7bbc 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -44,8 +44,8 @@ jupyterhub: extraCommandLineFlags: # set the timeout and proxyTimeout to 24 hours (arg is in milliseconds) # https://github.com/http-party/node-http-proxy?tab=readme-ov-file#options - - "--timeout 86400000" - - "--proxyTimeout 86400000" + - "--timeout=86400000" + - "--proxyTimeout=86400000" resources: requests: # FIXME: We want no guarantees here!!! From bb8e6e83977c9b1dbfd08bf3808629f659626037 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 2 Feb 2024 16:22:44 -0800 Subject: [PATCH 5/9] add a dash to cli arg --- hub/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hub/values.yaml b/hub/values.yaml index 9bc8a7bbc..1deffcbb1 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -45,7 +45,7 @@ jupyterhub: # set the timeout and proxyTimeout to 24 hours (arg is in milliseconds) # https://github.com/http-party/node-http-proxy?tab=readme-ov-file#options - "--timeout=86400000" - - "--proxyTimeout=86400000" + - "--proxy-timeout=86400000" resources: requests: # FIXME: We want no guarantees here!!! From 7f216c9491adf0bc39108036ac51171c2af6b94e Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 2 Feb 2024 16:28:37 -0800 Subject: [PATCH 6/9] chartpressed --- hub/Chart.yaml | 2 +- node-placeholder/Chart.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hub/Chart.yaml b/hub/Chart.yaml index cf661ba18..104d3cd37 100644 --- a/hub/Chart.yaml +++ b/hub/Chart.yaml @@ -2,4 +2,4 @@ apiVersion: v1 appVersion: '1.0' description: Deployment Chart for JupyterHub name: hub -version: 0.0.1-0.dev.git.7370.h98d3927c +version: 0.0.1-0.dev.git.7432.hbb8e6e83 diff --git a/node-placeholder/Chart.yaml b/node-placeholder/Chart.yaml index 7c30b8b3b..c1454bfee 100644 --- a/node-placeholder/Chart.yaml +++ b/node-placeholder/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.0.1-0.dev.git.7305.h0a2e62d9 +version: 0.0.1-0.dev.git.7371.h371a4a22 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to From 9c1949f14fae2967217d6178672f053a3dd2e6e2 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 9 Feb 2024 15:48:58 -0800 Subject: [PATCH 7/9] remove timeouts --- hub/Chart.yaml | 2 +- hub/values.yaml | 4 ++-- node-placeholder/Chart.yaml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hub/Chart.yaml b/hub/Chart.yaml index 104d3cd37..ddeacb1b7 100644 --- a/hub/Chart.yaml +++ b/hub/Chart.yaml @@ -2,4 +2,4 @@ apiVersion: v1 appVersion: '1.0' description: Deployment Chart for JupyterHub name: hub -version: 0.0.1-0.dev.git.7432.hbb8e6e83 +version: 0.0.1-0.dev.git.7433.h7f216c94 diff --git a/hub/values.yaml b/hub/values.yaml index 1deffcbb1..d84de4c16 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -44,8 +44,8 @@ jupyterhub: extraCommandLineFlags: # set the timeout and proxyTimeout to 24 hours (arg is in milliseconds) # https://github.com/http-party/node-http-proxy?tab=readme-ov-file#options - - "--timeout=86400000" - - "--proxy-timeout=86400000" + # - "--timeout=86400000" + # - "--proxy-timeout=86400000" resources: requests: # FIXME: We want no guarantees here!!! diff --git a/node-placeholder/Chart.yaml b/node-placeholder/Chart.yaml index c1454bfee..5bfd6fd39 100644 --- a/node-placeholder/Chart.yaml +++ b/node-placeholder/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.0.1-0.dev.git.7371.h371a4a22 +version: 0.0.1-0.dev.git.7433.h7f216c94 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to From d97afe240658a4f1c4a6c0c785d67efd05cf7800 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 20 Feb 2024 16:36:55 -0800 Subject: [PATCH 8/9] bump proxy ram as we have plenty --- hub/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hub/values.yaml b/hub/values.yaml index d84de4c16..54c54064a 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -53,7 +53,7 @@ jupyterhub: cpu: 0.001 memory: 64Mi limits: - memory: 1Gi + memory: 1.5Gi traefik: resources: requests: From f928307355139caa4f4f9c00792afe154603a832 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Wed, 21 Feb 2024 09:17:19 -0800 Subject: [PATCH 9/9] chartpressed --- hub/Chart.yaml | 2 +- node-placeholder/Chart.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hub/Chart.yaml b/hub/Chart.yaml index ddeacb1b7..97b12162f 100644 --- a/hub/Chart.yaml +++ b/hub/Chart.yaml @@ -2,4 +2,4 @@ apiVersion: v1 appVersion: '1.0' description: Deployment Chart for JupyterHub name: hub -version: 0.0.1-0.dev.git.7433.h7f216c94 +version: 0.0.1-0.dev.git.7435.hd97afe24 diff --git a/node-placeholder/Chart.yaml b/node-placeholder/Chart.yaml index 5bfd6fd39..0409200e0 100644 --- a/node-placeholder/Chart.yaml +++ b/node-placeholder/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.0.1-0.dev.git.7433.h7f216c94 +version: 0.0.1-0.dev.git.7434.h9c1949f1 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to