Googletest: should only download if explicitly requested

[hzeller]

Currently, Googletest is attempted to be downloaded unconditionally if tests are enabled

https://github.com/berkeley-abc/abc/blob/master/CMakeLists.txt#L116-L128

This is problematic for packaging, as

• in packaging context,s, the build is not allowed to connect to the 'net
• it is preferred to use the system-provided library.

So I suggest to only do that on some explicit, say -DABC_DOWNLOAD_GTEST, default false; by default it should just use the default googletest available on the system (1.14.0 is old enough that it should be available on all distros. ) using the include(GoogleTest) macro in CMake.

I see if I can get to it.

[hzeller]

Ah, just looking at git annotate... ohai @QuantamHD :)

[QuantamHD]

Why not download by default, and turn off if you're trying to package it? IMO we should optimize for dev velocity over packaging velocity

[hzeller]

IMHO is an antipattern. Developers who care do not want that, in particular the kind that like velocity :)
(also, it would always download stuff on next clean). If there should be some sort of rigid dependency, it should be a third_party/ submodule of sorts (also an antipattern, but slightly less worse).

Anyway, independent of the default, we first need an option to actually be able to choose, before we can define its default :)
I suggest something like -DABC_USE_SYSTEM_GTEST.

[sarnold]

This is in my (ignored) PR here

[hzeller]

I like that @sarnold - can you make pull request against berkely-abc ? Looks like your link points to a fork but not a PR.