Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion(Resub): Potential bug point when collecting divisor. #324

Open
wjrforcyber opened this issue Aug 23, 2024 · 0 comments
Open

Discussion(Resub): Potential bug point when collecting divisor. #324

wjrforcyber opened this issue Aug 23, 2024 · 0 comments

Comments

@wjrforcyber
Copy link
Contributor

Just a discussion here.
Anyone has encountered with core dump when collecting divisors in resub?
Sorry I couldn't provide detailed bug point or any BLIF here since the case is quite huge.
Me myself seldom see resub crash either, but from the stack trace report, it seems the Abc_ObjFanin0 or Abc_ObjFanin1 has crashed.
Code block:

void Abc_ManResubCollectDivs_rec( Abc_Obj_t * pNode, Vec_Ptr_t * vInternal )
{
    // skip visited nodes
    if ( Abc_NodeIsTravIdCurrent(pNode) )
        return;
    Abc_NodeSetTravIdCurrent(pNode);
    // collect the fanins
    Abc_ManResubCollectDivs_rec( Abc_ObjFanin0(pNode), vInternal );
    Abc_ManResubCollectDivs_rec( Abc_ObjFanin1(pNode), vInternal );
    // collect the internal node
    if ( pNode->fMarkA == 0 ) 
        Vec_PtrPush( vInternal, pNode );
}

Is there any chance that const node would show up during collection? Should we check the node type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant