perf: use ValueListBuilder
for PrivatePrintLeadingTrivia
#1532
+52
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ValueListBuilder
toPrivatePrintLeadingTrivia
saving 0.55 MBValueListBuilder.Pop
- this is an unmodified copy of microsoftsPop
Insert(int index, T item)
ValueListBuilder.ToList
this is becauseCompilationUnit
needs the resultingIList<Doc> contents
to be an actualList<Doc>
instead of an array.CompilationUnit.Print
to not need a mutable list WDYT.This isn't a massive saving I can close this if you like. I suspect this is more impactful for projects with a lot of comments and summaries though.