checkFolderRootline in CheckPermissions->checkFolderRootLineAccess() will return wrong result under some circumstances

[AlexKvrlp]

problem

if some files are in different storages, but its parent folders has the same names, CheckPermissions->checkFolderRootLineAccess() will only return the correct value for the first file.

how to reproduce

Conditions

• create two storages with non public basePathes (out of web-root)
• set permissions only to one storage, but not for the other storage.
• add one example file to each storage directly into the storage root.

Test-Implementation

We need to invoke the BeechIt\FalSecuredownload\SecurityCheckPermission for both files.
I'm using an uploads content element, so that I can iterate over both files.
Then use BeechIt\FalSecuredownload\ViewHelpers\Security\AssetAccessViewHelper to check file permission.
Output the values which are return from AssetAccessViewHelper.

cause

CheckPermissions->checkFolderRootLineAccess() did'not take storage into account while generating the cache Identifier. The hashedIdentifier is only unique for its storage. So, the getHashedIdentifier() will return the same value for equals folder names.

solution

We need to take the storage into account while generating the cache identifier.

I will add an pull request soon.