Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is output buffering still required in BePublicUrlController.php? #168

Open
stefanisak opened this issue Nov 4, 2021 · 0 comments
Open

Comments

@stefanisak
Copy link
Contributor

‪dumpFileContents() has been removed in TYPO3 10 and was therefore migrated to streamFile().

AFAIK streamFile returns a PSR-7 response object that already handles the output. So is there any reason to still call ob_start()?

741cd22#diff-fec66ec3406f8a33b116f572da3c744422e5e58870a408d0d9d14c88e5bf8a2dL84

In most cases it doesn't break anything, but I have the impression that with large files it sometimes causes a content length mismatch. But I can't really explain that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant