Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making "Flag to en-/disable rendering of BE user link instead of FE link" #151

Open
msollmann opened this issue Oct 5, 2020 · 2 comments

Comments

@msollmann
Copy link

I need to generate FE file links via a scheduler task and secure them via fal_securedownload. Unfortunately fal_securedownload generates BE links instead of FE links because of the hard coded option "Flag to en-/disable rendering of BE user link instead of FE link" in Classes/Aspects/PublicUrlAspect.php.

Would it be possible to make this option configurable?

@msollmann
Copy link
Author

...or to insert

if ($GLOBALS['_REQUEST']['tx_scheduler'])
   $this->enabled = false;

at the beginning of generatePublicUrl() in PublicUrlAspect.php. This would exclude all scheduler tasks from rendering BE user links.

@frans-beech-it
Copy link
Contributor

we didn't want to disable it in general for the scheduler.

Have a look at our solution for solr fal where we disable is for it's scope https://github.com/beechit/fal_securedownload/blob/master/Classes/Aspects/SolrFalAspect.php#L65

But maybe it's an idea to disable it in general when in scheduler context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants