Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error with "simplifiedControllerActionDispatching" feature #125

Open
echavaillaz opened this issue Sep 3, 2019 · 6 comments
Open

Comments

@echavaillaz
Copy link
Contributor

Hi,

When you try to show a file in a protected storage from the backend (file list module), there is a fatal error:

Too few arguments to function BeechIt\FalSecuredownload\Controller\BePublicUrlController::dumpFile(), 1 passed and exactly 2 expected

Additionally the thumbnail is not generated as expected in the file list module (due to the same error).

When I put the "simplifiedControllerActionDispatching" feature to false, alls is working well.

In fact you just have to update the method signature from public function dumpFile(ServerRequestInterface $request, ResponseInterface $response) to public function dumpFile() to solve the issue.

Thanks

@frans-beech-it
Copy link
Contributor

Hi,

what TYPO3 version did you use/try?

Frans

@echavaillaz
Copy link
Contributor Author

Oh sorry, TYPO3 9.5.9. I think it is ok with v8 but not sure.

@dominikmuellerwf
Copy link

Hi,
Same error here with TYPO3 9.5.11.
Dominik

@frans-beech-it
Copy link
Contributor

What version of fal_secure_download do you use?

@geldmacher
Copy link

I can confirm this bug and the solution from @echavaillaz in TYPO3 9.5.15 with fal_secure_download 2.2.1. This is a problem in the FE, too. In general the dumpFile mechanismn is not working.

@nilsmehnert
Copy link

TYPO3 9.5.20 still to the same problem.
I changes line 29 in the BePublicUrlController to:
public function dumpFile(ServerRequestInterface $request, ResponseInterface $response = null)
to make it work till there is an official fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants