Rotate some Flickr images before sideloading them #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #20 by retrieving the Flickr "rotation" property for photos being imported and, if rotation is needed, fixes the image before sideloading it.
This introduces a 6th parameter to the
sideload_mediafunction - a$local_filesarray that is meant to complement the original$urlsarray. If there is a local file value set for a given URL, the function will now use that as the source for the sideload, keeping everything else the same. This should give other importers the flexibility to perform media transformations prior to import, without the performance hit of post-import changes and related thumbnail regeneration.I've tested this locally with a variety of images, but haven't yet run my full Flickr library through it.